Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend oomox compatibility to other custom themes? #94

Closed
Warmuser opened this issue Aug 16, 2017 · 17 comments · Fixed by nana-4/materia-theme#187
Closed

Extend oomox compatibility to other custom themes? #94

Warmuser opened this issue Aug 16, 2017 · 17 comments · Fixed by nana-4/materia-theme#187

Comments

@Warmuser
Copy link

Warmuser commented Aug 16, 2017 •
edited
Loading

There are many interesting themes to customize, could be possibile to extend the oomox compatibility with other custom themes like:

Let me know if it possible, thanks! :)
@actionless
Copy link
Member

actionless commented Aug 19, 2017 •
edited
Loading

yes, it's possible (in the same way how now icon theme is being selected)
i will be happy to merge to oomox pull requests with any new themes

@Warmuser
Copy link
Author

Warmuser commented Aug 19, 2017 •
edited
Loading

Ok thanks, anyway I want to add also Vimix (Numix variant) to the request, because its a really valid and complete theme. :)

@actionless
Copy link
Member

btw i forgot to mention what it won't be possible for any themes which are using any bitmap image assets (they first should be replaced to SVG)

This was referenced Aug 20, 2017
Closed
Open
Closed
Open
Closed
@Warmuser
Copy link
Author

Ok, I opened some compatibility requests for oomox. :)

@actionless
Copy link
Member

thanks! please mention me with an @ if it will be needed any my input in those conversations

@Warmuser
Copy link
Author

Ok :)

@actionless
Copy link
Member

actionless commented Aug 27, 2017 •
edited
Loading

Flat-Plat is ready, all other which you listed quite similar to it, except for arc-theme, i personally like arc and vertex themes

@Warmuser
Copy link
Author

Warmuser commented Aug 28, 2017 •
edited
Loading

Fantastic! Thank you @actionless and @nana-4 :) , anyway I have some problems to update with pamac. I will try a fresh installation of omox and flat-pat. :)

This is the log:

Synchronizing package databases...
Starting full system upgrade...

Preparing...

Building oomox-git...
Cloning into 'oomox-git'...
remote: Counting objects: 204, done.
remote: Compressing objects: 100% (170/170), done.
remote: Total 204 (delta 69), reused 143 (delta 33)
Receiving objects: 100% (204/204), 35.46 KiB | 3.22 MiB/s, done.
Resolving deltas: 100% (69/69), done.
==> Making package: oomox-git 1.3.0-2 (Mon Aug 28 18:20:11 CEST 2017)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> Retrieving sources...
-> Cloning oomox git repo...
Cloning into bare repository '/tmp/pamac-build-manjaro/oomox-git/oomox'...
remote: Counting objects: 15192, done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 15192 (delta 2), reused 12 (delta 1), pack-reused 15174
Receiving objects: 100% (15192/15192), 8.72 MiB | 1.51 MiB/s, done.
Resolving deltas: 100% (8231/8231), done.
-> Cloning oomox-gtk-theme git repo...
Cloning into bare repository '/tmp/pamac-build-manjaro/oomox-git/oomox-gtk-theme'...
remote: Counting objects: 14014, done.
remote: Total 14014 (delta 0), reused 0 (delta 0), pack-reused 14014
Receiving objects: 100% (14014/14014), 8.84 MiB | 1.12 MiB/s, done.
Resolving deltas: 100% (7587/7587), done.
-> Cloning Flat-Plat git repo...
Cloning into bare repository '/tmp/pamac-build-manjaro/oomox-git/Flat-Plat'...
remote: Counting objects: 9525, done.
remote: Total 9525 (delta 0), reused 0 (delta 0), pack-reused 9525
Receiving objects: 100% (9525/9525), 29.26 MiB | 1.47 MiB/s, done.
Resolving deltas: 100% (5890/5890), done.
==> Validating source files with md5sums...
oomox ... Skipped
oomox-gtk-theme ... Skipped
Flat-Plat ... Skipped
==> Extracting sources...
-> Creating working copy of oomox git repo...
Cloning into 'oomox'...
done.
Switched to a new branch 'makepkg'
-> Creating working copy of oomox-gtk-theme git repo...
Cloning into 'oomox-gtk-theme'...
done.
Switched to a new branch 'makepkg'
-> Creating working copy of Flat-Plat git repo...
Cloning into 'Flat-Plat'...
done.
Switched to a new branch 'makepkg'
==> Starting prepare()...
Submodule 'flat-plat-theme' (https://github.com/nana-4/Flat-Plat.git) registered for path 'flat-plat-theme'
Submodule 'gtk-theme' (git@github.com:actionless/oomox-gtk-theme.git) registered for path 'gtk-theme'
Cloning into '/tmp/pamac-build-manjaro/oomox-git/src/oomox/flat-plat-theme'...
Cloning into '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme'...
The authenticity of host 'github.com (192.30.253.112)' can't be established.
RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8.
Are you sure you want to continue connecting (yes/no)? y
Please type 'yes' or 'no': yes
Warning: Permanently added 'github.com,192.30.253.112' (RSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:actionless/oomox-gtk-theme.git' into submodule path '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme' failed
Failed to clone 'gtk-theme'. Retry scheduled
Cloning into '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme'...
Warning: Permanently added the RSA host key for IP address '192.30.253.113' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:actionless/oomox-gtk-theme.git' into submodule path '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme' failed
Failed to clone 'gtk-theme' a second time, aborting
==> ERROR: A failure occurred in prepare().
Aborting...

@actionless
Copy link
Member

submodule names need to be updated in PKGBUILD, now it should work fine

@untoreh
Copy link

untoreh commented Nov 15, 2017 •
edited
Loading

the materia theme style does not allow menu/toolbar text, is that a limitation of the theme itself? Because the effective menu/toolbar text color is inherited from the background color and not even from the foreground/text color

@actionless
Copy link
Member

sorta, in original theme those colors are the same as well, i can later on add an option to switch between using such pattern as currently (as in normal Materia theme) and using the same colors as normal background (as in Materia-Light theme)

@actionless actionless mentioned this issue Nov 15, 2017
Merged
@actionless
Copy link
Member

since there was no feedback from other themes' devs i think this can be closed by now

@untoreh
Copy link

untoreh commented Dec 3, 2017

I think right click menus have the same problem

@actionless
Copy link
Member

@untoreh i've reported that issue already: nana-4/materia-theme#183 (comment)

@actionless
Copy link
Member

@untoreh fixed in c69a336

@untoreh
Copy link

untoreh commented Dec 13, 2017

menu is fixed, however menubar background now has selection highlight color

@actionless actionless mentioned this issue Dec 13, 2017
Merged
@actionless
Copy link
Member

@untoreh please try with 3849cc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(change_color): do more precise substitution actionless/materia-theme
3 participants
@actionless @untoreh @Warmuser