Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some color variables are defined outside of _colors.scss #183

Closed
actionless opened this issue Dec 3, 2017 · 1 comment
Closed

Some color variables are defined outside of _colors.scss #183

actionless opened this issue Dec 3, 2017 · 1 comment

Comments

@actionless
Copy link
Collaborator

Here:

$opaque_fg_color: if($variant == 'light', $grey_900, $white);
$opaque_secondary_fg_color: if($variant == 'light', $grey_600, mix($white, $base_color, percentage(0.7)));
$opaque_disabled_fg_color: if($variant == 'light', $grey_500, mix($white, $base_color, percentage(0.5)));
$opaque_divider_color: if($variant == 'light', $grey_300, mix($white, $base_color, percentage(0.12)));

That's breaking recoloring the theme's highlighted dropdown.

@nana-4
Copy link
Owner

nana-4 commented Dec 3, 2017

You are right. I'll move those (and other remaining) color variables to _colors.scss.
Thanks for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants