-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootstrap and popper.js dependencie, yarn.lock update #53
Conversation
@skoyah - should you not also commit the updated version of |
@lucasmichot I'm kinda new when it comes to contributing, so I wasn't sure if the lock files should be committed to packages. Should I commit them? |
No worries @skoyah 👍 - Yes I would also commit the updated version of |
Ok @lucasmichot! Thanks for the info! Will do it asap! |
So @lucasmichot one more thing, how can I add the yarn.lock file to this PR? or should I delete this PR and create a new one? It seems the I've made some research and some people recommend to commit both files so people can use npm or yarn on their projects. But some other people say that when contributing to packages you should never commit those files. So maybe @themsaid could help us on this subject. |
Also add yarn.lock.
But we're not using Bootstrap anymore. We use TailwindCSS now. |
So @themsaid, that begs the question of maybe removing the unnecessary call to bootstrap an popper.js on the app.js file. |
This PR fixes #52 .