Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.json incorrectly formatted #12

Closed
mAAdhaTTah opened this issue Apr 25, 2020 · 6 comments · Fixed by #15
Closed

Package.json incorrectly formatted #12

mAAdhaTTah opened this issue Apr 25, 2020 · 6 comments · Fixed by #15

Comments

@mAAdhaTTah
Copy link

I'm getting a failure on a Travis build from this update. Looks like you just added a dual-module package. With type: module in the package.json, I think main should point to the ESM build or needs the .cjs extension.

Build is here: https://travis-ci.org/github/mAAdhaTTah/brookjs/jobs/679426871

I haven't written a dual module package, so I could be wrong on the fix, but the current implementation is def broken, unfortunately.

@RyanZim
Copy link
Contributor

RyanZim commented Apr 25, 2020

Yep, needs .cjs extension.

@onhate
Copy link

onhate commented Apr 25, 2020

for those using yarn and it's breaking because this is a nested dependency add this temporarily to package.json

"resolutions": {
    "is-promise": "2.1.0"
  },

see #13 (comment)

@d-513
Copy link

d-513 commented Apr 25, 2020

yeah this broke my package

@nprail
Copy link

nprail commented Apr 25, 2020

This issue breaks @angular/cli as well.

Solved it by pinning the version in the package-lock.json file like so:

"is-promise": {
  "version": "2.1.0",
  "resolved": "https://registry.npmjs.org/is-promise/-/is-promise-2.1.0.tgz",
  "integrity": "sha1-eaKp7OfwlugPNtKy87wWwf9L8/o=",
  "dev": true
}

@RyanZim
Copy link
Contributor

RyanZim commented Apr 25, 2020

PR opened: #15

@evicent
Copy link

evicent commented Apr 25, 2020

#12
solution here!

npm remove is-promise
npm install is-promise@2.1.0

Try and let your comments

u1-liquid added a commit to u1-liquid/misskey that referenced this issue Apr 25, 2020
ForbesLindesay pushed a commit that referenced this issue Apr 25, 2020
* Use correct paths for CJS and ESM compatibility

Fixes #12

Introduced in feb90a4

* Downgrade mocha to fix Node 6 tests
@then then locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants