Save virtual control positions, Closes #30 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
December 10, 2023 13:26
- control panel bounds can now live in the layout provider - import order
- tentative move to @uidotdev/usehooks for useLocalStorage - the implementation there satisfies our needs, with the exception of useInterval, the peer deps in use in this repo prevent me from using react@experimental at this time - packages are small enough and tree shaken properly, so this isnt a big blocker for me at this time - this fixes the issue of using an updater function when updating local storage data values
…r provider - definitions for this diverge here, as we want no value in the emulator provider for the current key bindings - defaults are synced for emulator volume
- fixes race conditions when setting default values, as the defaults are persisted to local storage instantly, unlike the behavior in usehooks-ts -> localStorage is not set by the default value
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Details
saves user controls, control panel, and screen positions/offsets when moved or resized
adds reset positions button and tour addition within the virtual controls form
larger refactor hoisting layout/initial positions state to context preserved in localStorage
partially moving to
@uidotdev/usehooksfor localStorage interactionsFeedback is welcome, feel free to leave comments here!
Technical details
lifts initial positions and drag/resize positions once edited to a context that is persisted to localStorage
issues with other hooks libraries prompted me to switch to
@uidotdev/usehooks, as multiple localStorage state updates without a re-render in between were used in the current approachswitch to controlled components for both
rndanddraggableelements to preserve and manage their layoutsDeploy Checklist