Adding Neumman and Dykstra algorithims. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichRick1
requested changes
May 1, 2024
…thods and fixing other minor problems
|
Hi, I just made two commits. In the first one I fixed the issues mentioned by @RichRick1. On the second commit I implemented Halpern's algorithm. I follow a similar structure for the convergence of the algorithm, with a given number of iterations and tolerance. Please tell me what you think about it @RichRick1 @AlexandreDeCamargo. |
RichRick1
requested changes
May 15, 2024
|
Alexandre de Camargo
reacted to your message:
From: Valerii Chuiko ***@***.***>
Sent: Wednesday, May 22, 2024 9:29:52 PM
To: theochem/PyCI ***@***.***>
Cc: Alexandre de Camargo ***@***.***>; Mention ***@***.***>
Subject: Re: [theochem/PyCI] Adding Neumman and Dykstra algorithims. (PR #57)
Caution:
External email.
Merged
#57 into master.
—
Reply to this email directly,
view it on GitHub, or
unsubscribe.
You are receiving this because you were mentioned.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.