Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanent Location #1

Closed
kimt33 opened this issue Nov 26, 2015 · 2 comments
Closed

Permanent Location #1

kimt33 opened this issue Nov 26, 2015 · 2 comments

Comments

@kimt33
Copy link
Collaborator

kimt33 commented Nov 26, 2015

In general, permanents, I think, can be applied to non-square matrices. The determinants too can be applied (except that they are always zero). There is this assert statement that requires the matrix to be square.

I can see why the Geminal.permanent can be a static method and that in the case of APIG, we will always only have permanents of square matrices.

I guess I'm just wondering if this needs to be moved to a "math" location. And if it does, then we should maybe remove the square matrix restriction.
@kimt33 kimt33 changed the title Permanent Permanent Location Nov 26, 2015
msricher added a commit that referenced this issue Dec 2, 2015
@msricher
Add additional Newton-solver options to newton()'s options kw-argument
825a6b4 
1. Make ftol and xtol arguments for newton() for inxcreased fine-tuning

2. Change test/test_newton.py to reflect change #1.

3. Organize test/test_newton.py into separated functions with purposeful names.
@msricher
Copy link
Contributor

If we're looking at this module as a fancy-CI/Projected Schr. Equation module, then the permanent is one of these "f(C)" functions that determines the form of the wavefunction. For this reason, it might make sense to leave all "f(C)" functions inside their wavefunction class. This would include the permanent function.

@msricher
Copy link
Contributor

this is in the refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimt33 @msricher