This repository has been archived by the owner on Feb 13, 2019. It is now read-only.
testing out a fix for floating images in the editor #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@theonion/front-end I found this issue when testing for this ticket: https://app.asana.com/0/342156387987716/355037726440162
Purpose
Add a clearfix to the editor field so floating images don't fall outside of the editor box (particularly problematic on the live blog entries)
Test Link
http://editor-clearfix.test.avclub.com/cms
To test, create a new live blog entry, add an image, change the size to small or tiny (they both float right on av) and the box will expand to contain the image.