Skip to content
This repository has been archived by the owner on Feb 13, 2019. It is now read-only.

implement new lint rules #88

Merged
merged 2 commits into from
Jun 8, 2016
Merged

implement new lint rules #88

merged 2 commits into from
Jun 8, 2016

Conversation

collin
Copy link
Contributor

@collin collin commented Jun 8, 2016

no-else-return and "space-before-function-paren": [1, "never"],

@daytonn @kand re: some cleanup from review and getting the function paren style tightened down.

@collin
Copy link
Contributor Author

collin commented Jun 8, 2016

This looks big, but it's just linter stuff.

@kand
Copy link
Contributor

kand commented Jun 8, 2016

We should have spaces before function parens.

As with all linter rules we're splitting hairs, but it differentiates function calls from function definitions at a glance, given that function calls do not have spaces between the name and the parens.

@collin
Copy link
Contributor Author

collin commented Jun 8, 2016

I concur with your reasoning for switching space-before-function-paren from never to always.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.746% when pulling a2cd356 on lint-rule-changes into 064b604 on master.

@kand
Copy link
Contributor

kand commented Jun 8, 2016

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.746% when pulling c07e191 on lint-rule-changes into 064b604 on master.

@daytonn
Copy link

daytonn commented Jun 8, 2016

👍

@collin collin merged commit 4991533 into master Jun 8, 2016
@collin collin deleted the lint-rule-changes branch June 8, 2016 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants