Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many logs causing the app to freeze for a few seconds. #22

Closed
YoucefBen47 opened this issue Aug 15, 2022 · 6 comments · Fixed by #23
Closed

Too many logs causing the app to freeze for a few seconds. #22

YoucefBen47 opened this issue Aug 15, 2022 · 6 comments · Fixed by #23
Assignees
Labels
bug Something isn't working

Comments

@YoucefBen47
Copy link

We are using the sample ui in our app and I noticed many logs on events. When enabling a subtitle there are about 50+ cue logs that cause the app to freeze until the logs are done. On the example app I can comment the prints but how can I do that on our app ?
I only copied the example/src folder to our app. I tried copying the swift files but that changed nothing.
And also I implemented a play next functionality. on iOS when I play next episode it auto plays but on Android it stays paused.

@wvanhaevre
Copy link
Collaborator

Hi @YoucefBen47 , it looks like we forgot to disable the debug logging in our iOS Bridge when releasing the latest version of the package. I'll fix that and prepare an update today

@tvanlaerhoven tvanlaerhoven added the bug Something isn't working label Aug 19, 2022
@wvanhaevre wvanhaevre self-assigned this Aug 19, 2022
@wvanhaevre wvanhaevre linked a pull request Aug 19, 2022 that will close this issue
@wvanhaevre
Copy link
Collaborator

The PR is merged and the fix will be part of the v1.5.0 release of the react-native-package

@wvanhaevre
Copy link
Collaborator

@YoucefBen47 Did you have a chance to check if the logging has been disabled successfully? If ok, we can close this ticket.

@YoucefBen47
Copy link
Author

YoucefBen47 commented Aug 30, 2022 via email

@wvanhaevre
Copy link
Collaborator

My mistake. Indeed, the log fix was not released yet

@tvanlaerhoven
Copy link
Member

v1.5.0 was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants