-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Mission Story Progression #68
Added Mission Story Progression #68
Conversation
This error popped up when trying to download a contract via tools.cmd
Happens rarely, see https://discord.com/channels/826809653181808651/1058021993661861938 for an explanation.
Why weren't they there before?
I've not properly looked at this yet, but from a glance. You do delete the import of Destinations.json, but you never actually deleted the file. |
You are correct. I added a commit to actually delete it. |
@@ -2,6 +2,7 @@ | |||
"parents": { | |||
"LOCATION_PARENT_ICA_FACILITY": { | |||
"Id": "LOCATION_PARENT_ICA_FACILITY", | |||
"Opportunities": 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems dangerous to hard-code this, perhaps we should check all contracts present on that location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the data merged from static/Destinations.json
, and I think we are safe enough to use it. I haven't seen any mods that attempt at adding mission stories, and I doubt we will get new missions from IOI that add mission stories (even Ambrose does not have any).
Features:
userdata
folder will reset the mission story progression.Fix:
Breaking change:
static/Destinations.json
was deleted, its information merged intostatic/LocationsData.json
.Note:
The game itself also tracks completed mission stories and send
PersistentBool
s to the server viaGamePersistentDataService/SaveData
to communicate this information. ThePersistentBool
s are in the following format:The implementation in this PR ignores the
PersistentBool
s sent by the game and instead tracks the mission stories on the server side for the following reasons:PersistentBool
s make it more challenging.PersistentBool
s contains all the mission stories ever completed in the game on any server, meaning it will also report mission stories that were only completed on official servers but not Peacock.PersistentBool
s.