Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image and text details on challenges page #71

Merged
merged 14 commits into from
Jan 8, 2023
Merged

Fix image and text details on challenges page #71

merged 14 commits into from
Jan 8, 2023

Conversation

moonysolari
Copy link
Member

RDIL and others added 14 commits December 28, 2022 15:54
@RDIL
Fix a bug causing an infinite loop when certain challenges are completed
66f0b63
@RDIL
Add missing locale strings
67d4f20
@RDIL
Bump version to v5.6.1
ccced30
@grappigegovert
Update axios to v1.2.2, fixing an 'unexpected end of file' error
1e505e9 
This error popped up when trying to download a contract via tools.cmd
@RDIL
Use the new axios across all workspaces
fd20845
@RDIL
Fix challenges being able to cause a recursion deadlock
72d7e3a 
Happens rarely, see https://discord.com/channels/826809653181808651/1058021993661861938 for an explanation.
@RDIL
Bump version to v5.6.2
714e9dc
@moonysolari
Merge branch 'v6' of https://github.com/thepeacockproject/Peacock int…
5ea114f 
…o v6
@moonysolari
Merge branch 'v6' of https://github.com/thepeacockproject/Peacock int…
c11e4d3 
…o v6
@moonysolari
Remove getChallengePlanningDataForContract
3f0d0a5 
Use getChallengeTreeForContract in its stead.
@moonysolari
Separate out the better function for switched data
90cba2d
@moonysolari
reduce calls of generateCompletionData
b70b837
@moonysolari
Use new switch data batcher for destination part
d2231c2
@moonysolari
Move Contract Not Found warning to resolveContract
a45e620
RDIL
RDIL approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - want a second look from either Tony or Tampy first though.

@moonysolari moonysolari changed the title Fix image and text details on challenge pages Fix image and text details on challenges page Jan 7, 2023
AnthonyFuller
AnthonyFuller approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything logically wrong with it, so LGTM. Thanks for all your recent contributions!

Also, I assume this makes the data we return to the game more like official's? Because I have remarked in the past that it's something we should probably do.

@moonysolari
Copy link
Member Author

Also, I assume this makes the data we return to the game more like official's? Because I have remarked in the past that it's something we should probably do.

It does indeed. I'd say this one is 98% similar to the official responses.

@RDIL RDIL merged commit d95553b into thepeacockproject:v6 Jan 8, 2023
@moonysolari moonysolari deleted the challenge-refactor branch January 10, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDIL RDIL RDIL approved these changes

@AnthonyFuller AnthonyFuller AnthonyFuller approved these changes

@atampy25 atampy25 Awaiting requested review from atampy25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image and text for empty categories are missing when filters are applied on challenge pages
4 participants
@moonysolari @AnthonyFuller @RDIL @grappigegovert