-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New saving/loading behaviors to fix bugs related to saving #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error popped up when trying to download a contract via tools.cmd
Happens rarely, see https://discord.com/channels/826809653181808651/1058021993661861938 for an explanation.
RDIL
requested changes
Jan 9, 2023
Mainly just consistency stuff, but one nullability concern. In general, we use |
Co-authored-by: Reece Dunham <me@rdil.rocks> Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
Co-authored-by: Reece Dunham <me@rdil.rocks> Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
Co-authored-by: Reece Dunham <me@rdil.rocks> Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
Co-authored-by: Reece Dunham <me@rdil.rocks> Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
Co-authored-by: Reece Dunham <me@rdil.rocks> Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
Co-authored-by: Reece Dunham <me@rdil.rocks> Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
Co-authored-by: Reece Dunham <me@rdil.rocks> Signed-off-by: moonysolari <118079569+moonysolari@users.noreply.github.com>
RDIL
approved these changes
Jan 9, 2023
RDIL
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you've tested this already, so LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with casual gameplay, both before and after restarting the game and Peacock.
New saving/loading behaviors
Saves
in user profiles.contractSessions
. The filename is in the format ofslot_token_sessionID.json
.Saves
field of the user is updated with new information.Other changes
SaveFile
s received from/authentication/api/userchannel/ProfileService/UpdateUserSaveFileTable
is correctly processed, such that the one with the latest timestamp is used instead of the last one in the list.contractSessions
is changed. They now have the slot name prepended.components/databaseHandler.ts
to avoid confusion. There were previously namedsessionid
s but none of them were IDs of a session.saveSession
andloadSession
were moved tocomponents/profileHandler.ts
.PeacockCChild
in user profiles.Issues likely fixed (need testing)