Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all broken challenges in #22 #82

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Fix all broken challenges in #22 #82

merged 3 commits into from
Jan 16, 2023

Conversation

moonysolari
Copy link
Member

  • Fixed all broken challenges currently on the broken challenges list in Broken challenges #22.
    • The Chameleon was fixed by correctly storing and loading the challenge progression across sessions, for challenges with a scope of "profile" or "hit".
    • The rest of the broken challenges were fixed by the new State Machine parser release.
  • All were confirmed via gameplay to be fixed and now have behaviors imitating those on the official server.

@moonysolari moonysolari added challenges Related to in-game challenges. dependencies Pull requests that update a dependency file labels Jan 16, 2023
@moonysolari moonysolari self-assigned this Jan 16, 2023
AnthonyFuller
AnthonyFuller approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hopefully all challenges work now!

@moonysolari
Copy link
Member Author

LGTM, hopefully all challenges work now!

Sadly no. The "Discover XX" challenges still don't work.

RDIL
RDIL approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sure hope this doesn't break anything

@RDIL RDIL merged commit d78d5bf into thepeacockproject:v6 Jan 16, 2023
@moonysolari moonysolari mentioned this pull request Jan 16, 2023
Closed
@moonysolari moonysolari deleted the fix-challenges branch January 17, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDIL RDIL RDIL approved these changes

@AnthonyFuller AnthonyFuller AnthonyFuller approved these changes

Assignees

@moonysolari moonysolari

Labels
challenges Related to in-game challenges. dependencies Pull requests that update a dependency file
Projects
Challenges & Progression
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moonysolari @AnthonyFuller @RDIL