Fix completion data generation function #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
generateCompletionData
function in #30 returns the parent location ID in theSubLocationId
field in its return value, which is not correct. It causes'UI_LOCATION_PARENT_XXX_TEXT'
to appear in the mission end screen, among other places. This PR restores the behavior that the sublocation ID should be in that field for most if not all purposes other than mastery. It also prevents location progression data from appearing in the bottom right for the sniper levels and the ICA facility, which is the correct behavior on official servers.