Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autolink extension URL detection #956

Merged

Conversation

LeSuisse
Copy link
Contributor

The extension was not detecting URI with a _ symbol correctly.

The issue was already fixed in the regex used by the Symfony project.
The regex used by the extension is updated to integrate all the changes that been made to it.

@colinodell colinodell self-assigned this Feb 15, 2023
The extension was not detecting URI with a `_` symbol correctly.
The issue was already fixed in the regex used by the Symfony project.
The regex used by the extension is updated to integrate all the changes
that been made to it.
@colinodell colinodell force-pushed the fix-autolink-extension-detection branch from 1a21bee to ce719fd Compare February 15, 2023 13:47
Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix!

@colinodell colinodell merged commit 4b78f59 into thephpleague:2.3 Feb 15, 2023
@LeSuisse LeSuisse deleted the fix-autolink-extension-detection branch February 15, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants