Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls Token in phpunit.xml.dst #12

Closed
marcaddeo opened this issue Dec 23, 2013 · 1 comment
Closed

Coveralls Token in phpunit.xml.dst #12

marcaddeo opened this issue Dec 23, 2013 · 1 comment

Comments

@marcaddeo
Copy link
Contributor

Hey Phil,

You have your projects coveralls.io token in the phpunit.xml.dist, do you think that should be removed? And kept in a phpunit.xml that is ignored by a gitignore?

Realized when I forked it was sending coveralls jobs to your token and possibly bringing down the projects code coverage percentage.

@philsturgeon
Copy link
Member

I don't think that is an issue, as only the master branch is really considered in that badge and yours are showing up correctly as pull requests:

https://coveralls.io/r/php-loep/fractal

Phil Sturgeon

On Monday, December 23, 2013 at 9:11 AM, Marc Addeo wrote:

Hey Phil,
You have your projects coveralls.io (http://coveralls.io) token in the phpunit.xml.dist, do you think that should be removed? And kept in a phpunit.xml that is ignored by a gitignore?
Realized when I forked it was sending coveralls jobs to your token and possibly bringing down the projects code coverage percentage.


Reply to this email directly or view it on GitHub (#12).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants