Change client-implementation to client-common. #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change php-http/client-implementation to php-http/client-common because this package changed it's name.
|
Can someone review and merge this, pls? I got the same issue. |
|
@barryvdh I think you may be the guy for this one. As it stands, it all works for me, so I really don't understand the problem. Not saying there isn't a problem - just don't understand it. Is this a production (non-dev) only issue? |
|
You're just missing a client implementation. This is a virtual package. See the readme |
|
aha, readme: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change php-http/client-implementation to php-http/client-common
because that package changed it's name.
This will solve issue:
composer missing dep: php-http/client-implementation ^1 #197
And composer is again able to install omnipay-common again.
Would you please be so kind to accept this pull request?
Thanks,
Noud