Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log http status bug #9

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix log http status bug #9

merged 1 commit into from
Oct 24, 2017

Conversation

ericwo
Copy link
Member

@ericwo ericwo commented Oct 24, 2017

No description provided.

@bodhi
Copy link
Member

bodhi commented Oct 24, 2017

More detail:

http.ResponseWriter will by default, write http.StatusOK if some code tries to write the response body without setting a HTTP status. But this logic was not recognised by the HTTPStatus middleware.

This change makes the middleware assume that the HTTP status will be 200 OK, unless someone tells it otherwise.

@bodhi bodhi merged commit 41553e3 into master Oct 24, 2017
@bodhi bodhi deleted the fix-request-status-code branch October 24, 2017 03:01
@bodhi bodhi restored the fix-request-status-code branch October 24, 2017 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants