Skip to content

Conversation

jmfayard
Copy link
Contributor

@jmfayard jmfayard commented Aug 20, 2019

Description

Hello, I refactored the Gradle build to use my plugin buildSrcVersions to manage dependencies.

The files {Libs,Versions}.kt have been generated with the command
$ ./gradlew buildSrcVersions

See https://github.com/jmfayard/buildSrcVersions

See this article https://dev.to/jmfayard/better-dependency-management-in-android-studio-3-5-with-gradle-buildsrcversions-34e9

Next Steps

Currently the versions in the dependencies are exactly the same as on master.

If you wish to update Kotlin, edit Versions.kt

If you want to update Gradle, run $ ./gradlew wrapper

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2019

CLA assistant check
All committers have signed the CLA.

@jmfayard jmfayard changed the title plugins.id("de.fayard.buildSrcVersions") Dependencies management with Gradle buildSrcVersions Aug 20, 2019
@maestromac
Copy link
Contributor

Thank you for this PR @jmfayard . We're definitely love any plugin that reduce headaches 😄

I'm hitting this error

Task 'buildSrcVersions' not found in root project 'DEV-Android'.

I checked your installation doc, is this caused by not adding buildSrcVersions to plugin block?

@jmfayard
Copy link
Contributor Author

@maestromac Correct! I don't know why this part didn't get commited. I don't have access to my development computer but hopefully I got the syntax right.

@jmfayard jmfayard force-pushed the feature/buildSrcVersions branch from a2b0da3 to 4637beb Compare September 3, 2019 14:32
@jmfayard
Copy link
Contributor Author

jmfayard commented Sep 3, 2019

@friederbluemle done and I git-rebased to keep the history clean

@jmfayard jmfayard force-pushed the feature/buildSrcVersions branch from 4637beb to f370bd1 Compare September 3, 2019 14:36
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants