-
Notifications
You must be signed in to change notification settings - Fork 95
Network Reachability #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Reachability #109
Conversation
This looks great. I'll take a look within the next day. @StriderHND wanna play around with this and offer some thoughts? |
Sure I'll checkout this @benhalpern , and give my comments. |
…the error banner for proper dismissal.
In 8681c0c I added an error banner as a lazy var, this is to provide access the banner to dismiss it since I'll be tackling the code climate issues soon. |
Changes suggested by code climate.
@chickdan the changes are looking good! I was gonna mention the issue with the Just fix the code climate issues and it's good to go. @benhalpern |
Having finally given it a full inspection, this is a fabulous first pass. This is an area we are going to want to keep improving on as a strength and this is an awesome start to iterate off. Amazing work @chickdan. |
Had some code laying around and plugged it in to get network detection going and added the NotificationBanner library for displaying a banner. Currently the only banner being displayed is when there is no network connection at all, but I plan on expanding the logic to display for various situations with corresponding messages.
This code is kind of old so I'm looking at using the Reachability.swift library which looks pretty similar but more refined.
Closes #103