Skip to content

Conversation

StriderHND
Copy link
Contributor

In this PR we add support to iPad devices as requested in the issue #100

Updating the project and doing some small refectory how the URL are loaded I created an extension to WKWebView creating a function called load in this version of load we send a string of the URL we need to load, creates a URL object and a URLRequest with that we assure that we do optional unwrapping of the string we need to load and update the wkwebview. with that now we can load URL string in the following way

webView.load("url_string-to_load")and not do all the optional boilerplate code to unwrap or request.

Storyboard Updates.

  • Added a UIToolbar to the ViewController storyboard
  • Updated the forward and back buttons from UIButton to UIBarButtons for the UIToolbar
  • Corrected constrains warnings on storyboards

If there is any questions please let me know

Erick

@chickdan
Copy link
Contributor

Great update, this looks so much better on iPad!

For future reference, and this applies to any project, it's best to keep unrelated changes as separate PRs just in case something doesn't work, a maintainer doesn't want certain changes, etc.

@benhalpern
Copy link
Contributor

This is great, will get to it soon.

@StriderHND
Copy link
Contributor Author

Great update, this looks so much better on iPad!

For future reference, and this applies to any project, it's best to keep unrelated changes as separate PRs just in case something doesn't work, a maintainer doesn't want certain changes, etc.

Sure I'll keep that in mind, thanks! @chickdan

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the constraints have been changed in a way that is no longer right on iPhone X

How it was:

How it is now:

There should be more space in between the bottom of the device and the icons.

@StriderHND
Copy link
Contributor Author

@benhalpern let me check this one right now.

@StriderHND
Copy link
Contributor Author

@benhalpern changes are made as requested all looks good across all iOS devices. please check.

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous

@benhalpern benhalpern merged commit bbb33a7 into forem:master Dec 19, 2018
@StriderHND StriderHND deleted the feature/iPad_support branch December 19, 2018 16:34
@maestromac maestromac mentioned this pull request Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants