-
Notifications
You must be signed in to change notification settings - Fork 95
Feature/iPad support #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/iPad support #112
Conversation
CFBundleURLTypes update
Haptic Feedback
network reachability
Great update, this looks so much better on iPad! For future reference, and this applies to any project, it's best to keep unrelated changes as separate PRs just in case something doesn't work, a maintainer doesn't want certain changes, etc. |
This is great, will get to it soon. |
Sure I'll keep that in mind, thanks! @chickdan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benhalpern let me check this one right now. |
@benhalpern changes are made as requested all looks good across all iOS devices. please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fabulous
In this PR we add support to iPad devices as requested in the issue #100
Updating the project and doing some small refectory how the
URL
are loaded I created an extension toWKWebView
creating a function calledload
in this version of load we send a string of the URL we need to load, creates aURL
object and aURLRequest
with that we assure that we do optional unwrapping of the string we need to load and update thewkwebview
. with that now we can load URL string in the following waywebView.load("url_string-to_load")
and not do all the optional boilerplate code to unwrap or request.Storyboard Updates.
If there is any questions please let me know
Erick