Handle Ten X Theme #231
Handle Ten X Theme #231
Conversation
There was a problem hiding this comment.
Thanks a lot for this @chickdan! The look & feel is way better now on Ten X Hacker theme.
You're right #229 is quite a refactor. I've been offline for a bit more than a week, but now that I'm back I'll be making an effort to touch that one up again before we can merge it as soon as possible.
Once this is ready I can create an issue to discuss the best way to approach the themes, because the refactor will be a bit different than what is currently visible in #229. I'll be happy to assign you for this theming follow up work since you're up for it 🙂
Thanks again for the contribution and also the patience!
|
@fdoxyz Thanks for reviewing! Unfortunately it wasn't until now that I saw Code Climate was blocking a merge. I removed some blank lines in order to get it to pass, hopefully that is fine since there's a big refactor coming up. If so would you mind approving again? Thanks! |
|
Sure thing, thanks for taking care of that @chickdan! |
What type of PR is this? (check all applicable)
Description
Added a check for the Ten X dark theme.
I noticed there is quite a bit of the project was refactored in #229 so once that is merged I will work on more proper theming capability.
Related Tickets & Documents
Closes #230
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?