chore/linting

[jenbutongit]

#83
🤞hopefully this separates test and linting stages.

Also don't want to be running carthage twice here, just for the tests. Moved it into it's own lane rather than before_all

TBD: ignore_exit_status might have to be set to true if we want to enforce linting but there'll be some work to fix these: Done linting! Found 1173 violations, 202 serious in 130 files. 😧

[CLAassistant]

All committers have signed the CLA.

[chickdan]

The reason I didn't include this fastlane step sooner is because we don't have a way to view the results of the PR's other people make. If we could get Danger (or something similar) added, that would be awesome!

[jenbutongit]

@chickdan ok! looks good. looks like someone needs to set up a bot account & API key. Happy to do so but probably best in the hands of @benhalpern / @jessleenyc?

[jessleenyc]

I think @maestromac might have some thoughts on this.

[maestromac]

Hey all. I'm not too familiar with Swift development but would it make sense to integrate Hound or CodeClimate to this repository instead of combining linting with Travis?

[chickdan]

Code Climate looks pretty robust, I think it would be a good idea to utilize it alongside Travis.

[jenbutongit]

@maestromac is this all ok? I'm not familiar with CodeClimate. I assume all that needs to be done now is @thepracticaldev to switch on CodeClimate for this repo.

[maestromac]

@jenbutongit Yup looks good. I just integrated CodeClimate to this repo. I will be pushing a blank commit to your work to attempt to trigger the webhook.

Also adding some badges

[jenbutongit]

hehe, since CC is turned on repo wide it looks like it's failing other builds. I'll add to the readme how to run the linter.

[maestromac]

LGTM!