Refactor/onboarding #1083
Merged
Refactor/onboarding #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use ternary for simple if-else cases (to reduce lines of code) - remove unecessary trailing else clause - destructure state variables - add a consistent return eg null when nothing is rendered - use prevState callback when new state depends on previous state - use switch case when toggling onboarding screens, constants easier to read imo.
|
|
maestromac
suggested changes
Nov 8, 2018
pr-triage
bot
added
PR: reviewed-changes-requested
… into refactor/onboarding
pr-triage
bot
added
PR: unreviewed
|
@maestromac thanks for the review addressed each comment 👍 |
maestromac
reviewed
Nov 14, 2018
maestromac
approved these changes
Nov 15, 2018
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I used code climate to determine what to change code climate link
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?