Add GitLab URL field to user profile #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benhalpern
approved these changes
Nov 15, 2018
pr-triage
bot
removed
the
PR: unreviewed
pr-triage
bot
added
PR: reviewed-approved
|
Hey @sidemt, this is live. Feel free to make a changelog post like these ones if you want: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Added GitLab URL field to user profile page and corresponding database/model/controllers.
This should close #1080 .
Regarding the validation of the URL, as far as I checked the GitLab's sign up form it does not have a limitation on the length of the username and it can contain
.or-in it.Related Tickets & Documents
#1080
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?