Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar-profile-snapshot width #2145

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@Link2Twenty
Copy link
Contributor

commented Mar 21, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

The 3 hardest problems programmers face are

  1. Naming things
  2. Off by 1 errors

.sidebar-profile-snapshot width was wider than the rest of the sidebar by 1px.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before:
image

After:
image

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed
Fix sidebar-profile-snapshot width
Width was 1px too wide
@maestromac
Copy link
Collaborator

left a comment

LGTM!

@maestromac maestromac merged commit 354f7f8 into thepracticaldev:master Mar 21, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@pr-triage pr-triage bot added the PR: merged label Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.