Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge user and give pro users trusted role #2176

Merged

Conversation

Projects
None yet
2 participants
@jessleenyc
Copy link
Collaborator

commented Mar 22, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • Automatically give "PRO" users trusted role. I'm sure PRO stuff will be moved out of this area soon but I think this makes sense for now.
  • Add merge user functionality to /internal.
  • Prevent merge if account to be deleted has two identities (likely indicator that this account shouldn't be deleted)

@benhalpern
Copy link
Collaborator

left a comment

Good stuff. The safe navigation operator alongside the conditional statement that is used in a few places here is redundant, but all around improvement as a PR. Pretty easy to follow along and see what's going on with this logic. Feel free to clean up little things as an additional PR.

@benhalpern benhalpern merged commit 1b0cb47 into thepracticaldev:master Mar 22, 2019

7 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
codeclimate/diff-coverage 94% (50% threshold)
Details
codeclimate/total-coverage 89% (0.0% change)
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@pr-triage pr-triage bot added the PR: merged label Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.