Extract "following" action from "show" in DashboardsController

[dabrorius]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Documentation Update

Description

Related Tickets & Documents

Currently several separate pages are all crammed under show action of DashboardsController.
This is the first step in an attempt of refactoring that action and separating it into several smaller controller actions.

Added to documentation?

• docs.dev.to
• readme
• no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

[lightalloy]

Great 👍
I suggest adding request and feature specs for the /dashboard/following along with this refactoring.

[dabrorius]

@lightalloy there are request specs covering this pretty well (https://github.com/thepracticaldev/dev.to/blob/master/spec/requests/dashboard_spec.rb#L59). Do you feel there's a need for feature specs on top of this?

[lightalloy]

@dabrorius Oops, missed these specs somehow, sorry.
In my opinion, it would be nice to have feature specs on this feature.
Maybe it's ok to have them (later) in another pr 🤔

[dabrorius]

@lightalloy I can add feature specs as part of this PR, but I'm not sure what to test in it. I'd like to avoid adding redundant feature tests as they would slow the test suite down and would not bring any value.

What do you feel should be tested in the feature spec that is not already tested in the request spec?

[lightalloy]

@dabrorius I reviewed the existing specs again and now I agree with you that probably it's enough to have only requests specs for this functionality. However, I would add checks for the presence of the Followed users (1) and so on to the request specs.

[dabrorius]

@lightalloy Makes sense, I'll expand the request specs.

[dabrorius]

@lightalloy I've added new specs as discussed. I had to re-organize the specs as rubocop started complaining that I'm nesting specs too deep.

[lightalloy]

@dabrorius Great! That was not obviously the problem of this pr, but I'm trying to make sure that we increase the test coverage when it's possible.
Thanks for your refactoring 🌞

[maestromac]

Nice! Thanks for this!