"/videos" #2291
"/videos" #2291
Conversation
app/views/videos/index.html.erb
Outdated
| @@ -0,0 +1,3 @@ | |||
| <% @video_articles.each do |video_article| %> | |||
| <%= render "articles/video_player", meta_tags: false, article: video_article %> | |||
There was a problem hiding this comment.
This is a good thought, but we've switched on the main feed to just showing the image which click through and land you on the page, rather than the literal player, which is a pretty heavy burden on the page.
This is the index code, note the video url as the BG image and the video-camera.svg icon and duration. The icon is probably not necessary on a page made only of images.
<% if story.video.present? && story.video_thumbnail_url.present? %>
<a class="single-article-video-preview" style="background-image:url(<%= story.cloudinary_video_url %>)" href="<%= story.path %>">
<div class="single-article-video-duration">
<img src="<%= asset_path("video-camera.svg") %>" /><%= story.video_duration_in_minutes %></div>
</a>
<% end %>
So basically this will be a grid full of videos and their titles under them. We can fiddle with design.
There was a problem hiding this comment.
oh! that makes much more sense than having them be play-able. I don't know why I was trying to do that, esp cause the controls weren't showing up. Glad I pushed this sooner than later.
| class VideosController < ApplicationController | ||
| after_action :verify_authorized | ||
| after_action :verify_authorized, except: %i[index] | ||
|
|
There was a problem hiding this comment.
Check out the pages_controller for the simplest example of applying edge caching to the page. (set_cache_control_headers and set_surrogate_key_header)
Then the page will need to be busted at appropriate times, like any other page.
| resources :events, only: %i[index show] | ||
| resources :additional_content_boxes, only: [:index] | ||
| resources :videos, only: %i[create new] | ||
| resources :videos, only: %i[index create new] |
| end | ||
|
|
||
| def index | ||
| @video_articles = Article.where.not(video: nil, video_thumbnail_url: nil).where(published: true).order("published_at DESC").page(params[:page].to_i).per(12) |
There was a problem hiding this comment.
We will also need to add a set_surrogate_key_header call here to go along with set_cache_control_headers above.
Full details her: https://github.com/fastly/fastly-rails
| def create | ||
| authorize :video | ||
| @article = ArticleWithVideoCreationService.new(article_params, current_user).create! | ||
| CacheBuster.new.bust "/videos" |
There was a problem hiding this comment.
I think this should probably go in the general article cachebusting spot under the conditional that the article has a video.
This is because the create event here doesn't correlate with a new video being published, which is tied to the article's usual lifecycle.
| expires_in: 10.minutes | ||
| respond_to :json | ||
|
|
||
| caches_action :show, |
There was a problem hiding this comment.
This is left over from a copy and paste, eh? No show action in this controller.
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
What type of PR is this? (check all applicable)
Description
Adds a page (/videos) to see all posts w. native video content.