Skip to content

Add tests to PodcastEpisodesController #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2019
Merged

Add tests to PodcastEpisodesController #2297

merged 2 commits into from
Apr 3, 2019

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Apr 3, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This PR does two things:

  • adds tests for the Api::V0::PodcastEpisodesController
  • removes unused routes and code

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

rhymes added 2 commits April 3, 2019 13:30
@rhymes
Add tests for existing API PodcastEpisodesController
51e93d4
@rhymes
Generate only index route
0303596 
There's no need to generate all routes if they are not implemented
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 3, 2019
benhalpern
benhalpern approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@benhalpern benhalpern merged commit dc2414c into forem:master Apr 3, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Apr 3, 2019
@rhymes rhymes deleted the rhymes/api-podcasts-episodes branch April 3, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged PR: reviewed-approved bot applied label for PR's where reviewer approves changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhymes @benhalpern