Set users email to nil instead of blank #2305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
PR: reviewed-approved
lightalloy
force-pushed
the
users-email-index
branch
from
ee864e7 to
3988560
Compare
|
One of the tests is failing on the CI though it succeeds locally. Does anyone have ideas on this? |
|
I see, it tries to find |
pr-triage
bot
added
PR: merged
|
Yeah that's actually what motivated me to write this article |
|
@maestromac thanks, I hadn't read it before, so I had to do the research myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Since the unique key was added to the
users.emailblank values will be considered as duplicated.Users don't always have emails specified, so we have to allow
nullvalues in the database and make sure there are no attempts to write blank emails into the database.Related Tickets & Documents
#2061