Darken tag following weight input's background #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
benhalpern
approved these changes
Apr 6, 2019
pr-triage
bot
added
PR: reviewed-approved
|
Nice! |
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This was a small change, so I did not take the time to run the app locally. This article said it was acceptable so I hope this is ok 🙂
I now find the button color a bit weird.
Also I noticed there is no
--theme-button-colorfixed now for the night mode, could it be a good idea, to replace this one, and maybe theSaveone on the home feeds ?What do you think ? I can open an issue if needed.
Related Tickets & Documents
Resolves #2184
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
No screenshot as I didn't run the app. Only one color change so it's should be ok.
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?