Don't make additional SQL query on remembering user #2335
Merged
+55
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightalloy
commented
Apr 8, 2019
| user.name = auth.info.nickname if user.name.blank? | ||
| user.skip_confirmation! | ||
| user.remember_me! | ||
| user.remember_me = true |
There was a problem hiding this comment.
Setting remember_me doesn't change anything, because User#remember_me always returns true
https://github.com/thepracticaldev/dev.to/blob/dbac5f6d190913a3dab669d94d6ba73dd8e09a94/app/models/user.rb#L273-L275
rhymes
reviewed
Apr 8, 2019
benhalpern
approved these changes
Apr 8, 2019
pr-triage
bot
added
PR: merged
pr-triage
bot
added
PR: reviewed-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
rememberfields w/o immediate write to the databaseAuthorizationServiceRelated Tickets & Documents
#2061