Skip to content

Conversation

lightalloy
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor

Description

  • moved logic to a separate class
  • create a separate job
  • kept the old estimate_default_language_without_delay! method in case there will be existing jobs using it

Related Tickets & Documents

Prepare to fix #2368

@lightalloy lightalloy changed the title [WIP] Move estimating user default language to ActiveJob Move estimating user default language to ActiveJob Apr 11, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 11, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 13, 2019
@benhalpern benhalpern merged commit d27874a into forem:master Apr 13, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 13, 2019
@lightalloy lightalloy deleted the activejob/estimate-user-default-language branch March 9, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants