Skip to content

Remove unused attr_reader #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

Remove unused attr_reader #2376

merged 1 commit into from
Apr 11, 2019

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Apr 11, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

The request_id attr_reader usage has been removed in #2366

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 11, 2019
Zhao-Andy
Zhao-Andy approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 11, 2019
@maestromac maestromac merged commit a09bf20 into forem:master Apr 11, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 11, 2019
@rhymes rhymes deleted the patch-1 branch April 11, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Zhao-Andy Zhao-Andy Zhao-Andy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhymes @Zhao-Andy @maestromac