Skip to content

Conversation

venarius
Copy link

@venarius venarius commented Apr 11, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This fixes drafts in nightmode (dashboard)
Also changed the make video cta to now look more like a button

Keeping the background a bit more greyed-out so users can easily see that it's a draft 🙂

Related Tickets & Documents

Closes #2182

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before

Screenshot from 2019-04-11 18-50-02

After

Screenshot from 2019-04-11 19-03-34
Screenshot from 2019-04-11 19-03-15

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 11, 2019
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff, once the one change is made, this is good to go.

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 11, 2019
Co-Authored-By: venarius <tim.lange@online.de>
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Apr 12, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 12, 2019
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maestromac maestromac merged commit 6daec13 into forem:master Apr 12, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 12, 2019
@venarius venarius deleted the draft_nightmode branch April 12, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft articles in Night mode
4 participants