Skip to content

Conversation

lyonsbp
Copy link
Contributor

@lyonsbp lyonsbp commented Apr 11, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Fixes a typo in file community_moderation.html.erb

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2019

CLA assistant check
All committers have signed the CLA.

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 11, 2019
Copy link
Contributor

@jessleenyc jessleenyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lyonsbp, this actually isn't the typo! The spacing issue one is after the vomit emoji colon!

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 11, 2019
@lyonsbp
Copy link
Contributor Author

lyonsbp commented Apr 11, 2019

@jessleenyc Is this not still an issue though? There were two items broken up by a slash, one had a space between and one did not. This was intended?

@jessleenyc
Copy link
Contributor

@lyonsbp Actually, if you want to adjust the copy to

append "/mod" that would make it more clear!

@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Apr 11, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 11, 2019
@jessleenyc jessleenyc merged commit bab2b8b into forem:master Apr 11, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants