Skip to content

Conversation

desithorne
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

There was an incorrect " in the Thumbsdown description, so I changed it to match!

Related Tickets & Documents

Screenshot of the initial display: https://cl.ly/5e8a52d25344

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

proud gif!

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 11, 2019
@CLAassistant
Copy link

CLAassistant commented Apr 11, 2019

CLA assistant check
All committers have signed the CLA.

@jessleenyc
Copy link
Contributor

ha, great catch! I just approved another PR that fixes another issues in the same line. once that's merged, we can merge this one.

@jessleenyc
Copy link
Contributor

@desirottman just merged the other PR -- can you fix the merge conflict w/ your change?!

@desithorne
Copy link
Contributor Author

@jessleenyc should be all set now!

Copy link
Contributor

@jessleenyc jessleenyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 12, 2019
@maestromac maestromac merged commit 92eab3a into forem:master Apr 12, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 12, 2019
@desithorne desithorne deleted the patch-1 branch April 12, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants