Skip to content

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Apr 11, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

.touch() issues a SQL UPDATE statement to the database but it's not needed if it's contextual to an update or a save because they are both going to issue a SQL UPDATE.

This way we save some roundtrips back and forth from the DB.

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@rhymes rhymes changed the title [WIP] Use "touch" a little bit less Use "touch" a little bit less Apr 11, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 11, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 12, 2019
@benhalpern benhalpern merged commit 0d24dee into forem:master Apr 12, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 12, 2019
@rhymes rhymes deleted the rhymes/less-sql-statements branch April 12, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants