Skip to content

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Apr 12, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This PR fixes a couple of instances where The #{ApplicationConfig['COMMUNITY_NAME']} Community was written verbatim instead of replaced with the actual text.

I've also introduced an application helper called community_qualified_name with the full text.

FYI: there are some instances in the code of #{ApplicationConfig['COMMUNITY_NAME']} Community without the The and other instances of PracticalDev or DEV or other variations.

Related Tickets & Documents

Closes #2414

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@rhymes rhymes changed the title [WIP] Fix community name Fix community name Apr 12, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 12, 2019
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we can probably drop the "the", as DEV Community should be standard IMO. And this PR makes that standard easier to maintain!

@benhalpern benhalpern merged commit 1d9ef3a into forem:master Apr 13, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 13, 2019
@rhymes rhymes deleted the rhymes/community-name branch April 13, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged PR: reviewed-approved bot applied label for PR's where reviewer approves changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

og:site_name meta tag is broken
2 participants