Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed gems csv_shaper, bourbon and share_meow_client #2450

Merged
merged 1 commit into from Apr 15, 2019
Merged

Removed gems csv_shaper, bourbon and share_meow_client #2450

merged 1 commit into from Apr 15, 2019

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Apr 15, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Neither csv_shaper, nor bourbon, nor share_meow_client seems to be in usage anywhere in the code.

I've also removed the env variables for the Share Meow service

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

None of these gems seems to be in usage
@benhalpern
Copy link
Contributor

Thanks a lot. Yes, this is dead code related to old or abandoned features. I'm not entirely sure why Bourbon ever made it in.

@rhymes
Copy link
Contributor Author

rhymes commented Apr 15, 2019

Thanks a lot. Yes, this is dead code related to old or abandoned features. I'm not entirely sure why Bourbon ever made it in.

No worries, it happens a lot 😂. You add a gem, then you move on and forget to remove it and then it stays there forever.

I've written down a few others gem related fixups but I rather do them separately. I'm trying to avoid big PRs as much as possible 😂

@rhymes rhymes changed the title [WIP] Removed gems csv_shaper, bourbon and share_meow_client Removed gems csv_shaper, bourbon and share_meow_client Apr 15, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 15, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 15, 2019
@benhalpern benhalpern merged commit bf33490 into forem:master Apr 15, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 15, 2019
@rhymes rhymes deleted the rhymes/remove-unused-gems branch April 15, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants