Skip to content

[SMALL] UX: Fix comment preview loading in nightmode #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2019
Merged

[SMALL] UX: Fix comment preview loading in nightmode #2454

merged 1 commit into from
Apr 16, 2019

Conversation

venarius
Copy link

@venarius venarius commented Apr 15, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This fixes the comment preview loading animation in nightmode

Related Tickets & Documents

Closes #2359

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before

Screenshot from 2019-04-15 17-40-58

After

Screenshot from 2019-04-15 17-49-06
Screenshot from 2019-04-15 17-43-54

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 15, 2019
@venarius venarius changed the title UX: Fix comment preview loading in nightmode [SMALL] UX: Fix comment preview loading in nightmode Apr 15, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 15, 2019
@maestromac maestromac merged commit d39d30b into forem:master Apr 16, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 16, 2019
@venarius venarius deleted the markdown_preview_loading_nightmode branch April 16, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode & comments preview
3 participants