Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Anchor To Comments Section from Article #284

Merged
merged 1 commit into from Aug 8, 2018
Merged

Adding Anchor To Comments Section from Article #284

merged 1 commit into from Aug 8, 2018

Conversation

harnerdesigns
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • [ x ] Feature
  • Bug Fix

Description

Jumps user straight to comments section when they click on comments icon.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • [ x ] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

alt-text

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jack Harner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've talked about this but never gotten around to implementing. This is a simple improvement!

@benhalpern benhalpern merged commit c29e6a5 into forem:master Aug 8, 2018
@benhalpern
Copy link
Contributor

Jack confirmed he agreed to and signed the CLA. Possibly the emails don't link up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants