Improve the tag edit page (Tag moderators only) #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Forgot to mention that I'd like to work on an improved version of the colour picker. I didn't want to do those changes here as my main aim for this PR was to familiarise myself with the environment. 😄 |
timrodz
changed the title
Tags scss needed to be more cohesive with the entire DEV aeshetic, so I made the following changes: * Decreased the margin between the `tag-edit-container` and `tag-edit-tag areas`. * Added vertical margins to `tag-form-field` so that elements have a breathing room between them. * Increased the width of `tag-form-text-field` so that it's a bit easier to read, and changed its resizing mode to be vertical ONLY. Resizing a textarea should feel easy. * When clicking on a text field, the class `focus-visible` becomes active - The border color now becomes black. * Button `tag-edit-submit` was looking very unfamiliar with all other buttons. I didn't want it to be lonely, so I gave it attributes to match the 'WRITE A POST' CTA button. * `tag-edit-flash-error` will show background $red instead of the hardcoded hex value (#ff0000). Modify tags/edit.html.erb * The top area now shows a '#' sign next to the tag show section, e.g. '#beginner is the name of the tag used in Markdown.' * The order for text edit fields is now Summary, Wiki Markdown, Rules Markdown. The reason for this is that the Rules Markdown area feels like it's optional - Not every tag will have submission guidelines or specific rules. * Text area descriptions have changed a bit to try represent what they do better. Fix: import variables & mixin, refactor tag-edit
timrodz
force-pushed
the
feature/improve-tag-edit-page
branch
from
1cf2b9e
to
9310eb3
Compare
jessleenyc
approved these changes
Oct 2, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Since it's my first time working with Ruby, I decided to learn about ERB and do minor yet pleasing styling changes:
Textarearesizing is restricted to verticalRelated Tickets & Documents
Improve the tag edit pages #3953
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?