Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis S3 Artifact AddOn [4th attempt] #5760

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Fix Travis S3 Artifact AddOn [4th attempt] #5760

merged 1 commit into from
Jan 27, 2020

Conversation

maestromac
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Feature

Description

🤞

Related Tickets & Documents

n/a

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

n/a

Added to documentation?

  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 27, 2020
mstruve
mstruve approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please please please!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 27, 2020
Zhao-Andy
Zhao-Andy approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it 🚀

@maestromac maestromac merged commit a3569ef into forem:master Jan 27, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 27, 2020
@maestromac maestromac deleted the maestromac/travis/artifact-path branch January 27, 2020 16:33
@weekly-digest weekly-digest bot mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhao-Andy Zhao-Andy Zhao-Andy approved these changes

@mstruve mstruve mstruve approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maestromac @mstruve @Zhao-Andy