New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag provided but not defined: -w #1045

Open

muyuballs opened this issue Jan 17, 2020 · 1 comment

Contributor

muyuballs commented Jan 17, 2020 •

edited

Loading

ubuntu	19.10
Go	1.13.5
Qt	5.13.0

ERRO[0015] failed to run command  _func=RunCmd cmd="bash -c /opt/go/bin/go build -p 4 -v -trimpath -o xxx -tags=minimal -ldflags=all=\"-s\" \"-w\"" 
....
flag provided but not defined: -w

-w flag is lonely

qt/internal/cmd/deploy/build.go

Line 70 in 2b818d9

    
           cmd.Args = append(cmd.Args, fmt.Sprintf("-ldflags=%v%v", pattern, escapeFlags(ldFlags, ldFlagsCustom)))

qt/internal/cmd/deploy/build.go

Line 116 in 2b818d9

    
           cmd.Args = append(cmd.Args, fmt.Sprintf("-ldflags=%v%v", pattern, escapeFlags(ldFlags, ldFlagsCustom)))

escapedFlags might need '' like this:

cmd.Args = append(cmd.Args, fmt.Sprintf("-ldflags=%v'%v'", pattern, escapeFlags(ldFlags, ldFlagsCustom)))

The text was updated successfully, but these errors were encountered:

muyuballs added a commit to muyuballs/qt that referenced this issue


          fix : flag provided but not defined: -w

a46b859

issue @ therecipe#1045 (comment)

muyuballs mentioned this issue

fix: go build ldflags lonely #1046

Closed

domust commented Jan 20, 2020

Hi, I've also came across this exact problem. What was the reason for closing the pull request without merging? Was the implementation lacking in some way?

domust mentioned this issue

qt/internal/cmd/deploy: correcly escape ldflags on linux #1048

Open

therecipe mentioned this issue

qtdeplay fails to compile #1051

Closed

muesli mentioned this issue

Instalation #1060

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment