Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Colors Per URL #34

Merged
merged 1 commit into from
Aug 22, 2020
Merged

feat: Colors Per URL #34

merged 1 commit into from
Aug 22, 2020

Conversation

therynamo
Copy link
Owner

closes #33

Excited about this QOL feature. A great request from #33, and I think a much needed feature. Initially I think this was avoided due to very low caps on local storage limits. However, I think we'll be okay given the amount of sites one would have to enable this on is quite large to reach those limits.

feat: save color to url
@therynamo therynamo added the 🚀 feat A new feature! label Jul 27, 2020
@therynamo therynamo requested a review from postrad July 27, 2020 01:53
@therynamo therynamo self-assigned this Jul 27, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 183651292

  • 44 of 47 (93.62%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 92.655%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/helpers/chrome.ts 1 2 50.0%
src/content-scripts/helpers.ts 7 9 77.78%
Totals Coverage Status
Change from base Build 180169902: -0.5%
Covered Lines: 132
Relevant Lines: 140

💛 - Coveralls

@therynamo therynamo merged commit 4af677f into master Aug 22, 2020
@therynamo therynamo deleted the website-rules branch August 22, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 feat A new feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different rules for each website
2 participants