-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test_scheduler
#1045
Merged
kevinaboos
merged 6 commits into
theseus-os:theseus_main
from
tsoutsman:new-scheduler-test
Oct 5, 2023
Merged
Update test_scheduler
#1045
kevinaboos
merged 6 commits into
theseus-os:theseus_main
from
tsoutsman:new-scheduler-test
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new test is significantly more robust than the old one. As of right now, the test isn't particularly useful because we don't have task migration, but theseus-os#1042 adds implicit task migration when unblocking a task. Hence, the test has a focus on blocking and unblocking tasks. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
This was referenced Sep 17, 2023
Closed
kevinaboos
reviewed
Oct 3, 2023
kevinaboos
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1035 has been merged in, thanks!
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
kevinaboos
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* The new `test_scheduler` is significantly more robust than the old one. Currently, the test isn't particularly useful because we don't have task migration enabled, but #1042 will add implicit task migration when unblocking a task. * Hence, the test currently focuses on blocking/unblocking tasks. * Add a function to iterate over all initialized CPUs. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> e9416d6
github-actions bot
pushed a commit
to tsoutsman/Theseus
that referenced
this pull request
Oct 7, 2023
* The new `test_scheduler` is significantly more robust than the old one. Currently, the test isn't particularly useful because we don't have task migration enabled, but theseus-os#1042 will add implicit task migration when unblocking a task. * Hence, the test currently focuses on blocking/unblocking tasks. * Add a function to iterate over all initialized CPUs. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> e9416d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test is significantly more robust than the old one. As of right now, the test isn't particularly useful because we don't have task migration, but #1042 adds implicit task migration when unblocking a task. Hence, the test has a focus on blocking and unblocking tasks.