Add & and | operators to hull
#994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`graphic=no` adds the `-nographic` flag to the QEMU invocation. Supporting this required a few changes to `captain`. `terminal=(name of terminal)` e.g. `terminal=alacritty` will launch a new terminal window connected to `SERIAL2`. We do this by testing the next free TTY with `tools/free_tty` and assuming QEMU will use the same TTY. This may seem jank, but I think it's the only feasible solution. I've tested this on MacOS (side note: macOS makes it very hard to launch a new terminal window from the terminal) so if someone could test this on Linux as well that would be good. Also, I wasn't able to build for `aarch64` so the changes to `captain` need to be tested to ensure builds for `aarch64` didn't break. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
`concat!` prevents `format_args!` from capturing variables from the
surrounding scope. Implementing `println!` using a nested `format_args!`
removes this limitation allowing us to do the following:
```rust
let x = 3;
println!("{x}");
```
Similar to `std::println!`.
Also, the change [does not impact performance][1].
[1]: rust-lang/rust#106824
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Avoids disabling preemption for the duration of the program which can interfere with printing to the terminal. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
|
Depends on #1000. |
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
kevinaboos
reviewed
Jul 5, 2023
There was a problem hiding this comment.
This looks generally good so far. The one thing I'm unsure of is spawning another entire task to watch a new app task, but I suppose we could accept that heavyweight approach for now and work on a different monitoring mechanism later, e.g., a select-like operator.
I'm ok with accepting it as is, though I'll wait for our meeting tmrw to discuss it in person.
kevinaboos
approved these changes
Jul 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
`hull` is now almost feature complete. Not quite ready to replace the existing `shell` app, but is implemented better and more canonically than `shell`. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> 5c269ad
github-actions bot
pushed a commit
to kevinaboos/Theseus
that referenced
this pull request
Jul 6, 2023
…eus-os#994) `hull` is now almost feature complete. Not quite ready to replace the existing `shell` app, but is implemented better and more canonically than `shell`. Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com> 5c269ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
&and|operators, and implements thejobsandhistorycommands.